[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

[Gheorghe-Teodor Bercea via Phabricator via cfe-commits]

gtbercea marked an inline comment as done.
gtbercea added inline comments.


================
Comment at: lib/Driver/ToolChains/Cuda.cpp:217
+  std::vector<std::string> GPUArchNames;
+  // If this is an OpenMP action we need to extract the device architecture from
+  // the -march option.
----------------
hfinkel wrote:
> Do we have a test case for this?
Just added a test case for this.


================
Comment at: lib/Driver/ToolChains/Cuda.cpp:368
+  assert(!GpuArch.empty() && "Must have an explicit GPU arch.");
+  std::string LibDeviceFile;
 
----------------
Hahnfeld wrote:
> You can move the declaration down to the initialization
Done! Thanks for spotting that.


Repository:
  rL LLVM

https://reviews.llvm.org/D29647