[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

[Gheorghe-Teodor Bercea via Phabricator via cfe-commits]

gtbercea added inline comments.


================
Comment at: lib/Driver/ToolChains/Cuda.cpp:435
+
+    // TODO: get the compute capability from offloading arguments when not
+    // using the default compute capability of sm_20.
----------------
hfinkel wrote:
> gtbercea wrote:
> > hfinkel wrote:
> > > gtbercea wrote:
> > > > hfinkel wrote:
> > > > > Why is this a TODO? Is the necessary information not currently available in the offloading arguments, or are we just not grabbing it in this patch?
> > > > > 
> > > > This is for a future patch in which we will grab the compute capability from a special flag. I believe there has already been some discussion on the dev mailing list as to what that flag should be but I don't think there was a general consensus as to how that flag should be named.
> > > Which mailing list thread discussed this?
> > I believe it was openmp-dev. The proposal was initially posted by Gregory Rodgers.
> Can you please find it and post the link from here: http://lists.llvm.org/pipermail/openmp-dev/
> 
> I do recall discussing this at some point somewhere, but I'm not finding it in my email.
I managed to find the e-mail at last. It looks like it was a side conversation which ended with Justin Lebar suggesting Greg to post the discussion on the llvm-dev list. That post never happened. :-(


Repository:
  rL LLVM

https://reviews.llvm.org/D29647