[PATCH] D34506: Relax an assert in the comparison of source locations

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 26 07:23:40 PDT 2017


xazax.hun added a comment.

In https://reviews.llvm.org/D34506#787971, @joerg wrote:

> I don't think it is a good idea to make this function non-transitive.


I think this is a good point. However, I am not entirely sure that it is transitive right now. Check the "Both are in built-in buffers, but from different files" case, which is similar to the separate TU case. 
But I will look if I can come up with an alternative solution.


Repository:
  rL LLVM

https://reviews.llvm.org/D34506





More information about the cfe-commits mailing list