[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set
Daniel Jasper via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Jun 25 23:18:48 PDT 2017
djasper added a comment.
I don't want to move forward with this patch. But adding Manuel as another reviewer to sanity-check.
================
Comment at: include/clang/Format/Format.h:167
+ /// \endcode
+ OAS_StrictAlign,
+ };
----------------
The name is not intuitive. I don't think this is any more or less strict than the other version.
================
Comment at: unittests/Format/FormatTest.cpp:2781
+ verifyFormat("return (a)\n"
+ " // comment\n"
+ " + b;",
----------------
Comment seems to belong to "+ b" so should be aligned to it.
https://reviews.llvm.org/D32478
More information about the cfe-commits
mailing list