[PATCH] D34556: [libcxx] Annotate c++17 aligned new/delete operators with availability attribute

[Akira Hatanaka via Phabricator via cfe-commits]

ahatanak added inline comments.


================
Comment at: test/std/language.support/support.dynamic/new.delete/new.delete.placement/new_deployment.fail.cpp:12-16
+// test availability of new/delete operators introduced in c++17.
+
+#ifdef __APPLE__
+#undef _LIBCPP_DISABLE_AVAILABILITY
+#endif
----------------
dexonsmith wrote:
> There is a lit configuration to choose whether to run with availability or not.  We should just mark the test unsupported when we don't want it to run.
> 
> It's also important to run the rest of the suite with availability turned on, to see which other tests start to fail.
I added "REQUIRES: availability=macosx10.12" to avoid running this test when availability is turned off or we are targeting 10.13 or later.

I ran the tests with availability turned on and they all passed.


https://reviews.llvm.org/D34556