[PATCH] D34556: [libcxx] Annotate c++17 aligned new/delete operators with availability attribute

[Erik Pilkington via Phabricator via cfe-commits]

erik.pilkington added inline comments.


================
Comment at: test/std/language.support/support.dynamic/new.delete/new.delete.placement/new_deployment.fail.cpp:35
+  // expected-error at -10 {{call to unavailable function 'operator new[]': introduced in macOS 10.13}}
+  // expected-note at new:204 {{candidate function has been explicitly made unavailable}}
+  // expected-note at new:188 {{candidate function not viable: no known conversion from 'std::align_val_t' to 'const std::nothrow_t' for 2nd argument}}
----------------
You probably shouldn't include the line numbers here, it makes the test fragile. Ie, do `expected-note at new:*`


https://reviews.llvm.org/D34556