[PATCH] D34342: [OpenCL] Fix code generation of function-scope constant samplers.

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added a comment.

In https://reviews.llvm.org/D34342#785454, @bader wrote:

> Wow...
>  Nice catch.
>  For some reason I can't reproduce the problem neither.
>  I will drop source code change, but I'd like to modify the test anyway.


I think we probably had this issue at some point... Can't think of any recent commit that fixed it apart from may be r288163.

> https://reviews.llvm.org/rL277024 added test/CodeGenOpenCL/sampler.cl and modified test/SemaOpenCL/sampler_t.cl.
>  I want to move the parts of the test/SemaOpenCL/sampler_t.cl, which are supposed to pass semantic analysis to test/CodeGenOpenCL/sampler.cl and validate the LLVM IR after code generation.
>  Are you OK with this?

Sure. Sounds like a good improvement to testing! Thanks!


https://reviews.llvm.org/D34342