[PATCH] D34399: clang-format: introduce InlineOnly short function style

Francois Ferrand via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 21 04:52:09 PDT 2017


Typz marked 3 inline comments as done.
Typz added inline comments.


================
Comment at: include/clang/Format/Format.h:234
 
+  bool allowEmptyFunctionsOnASingleLine() const {
+      return AllowShortFunctionsOnASingleLine >= ShortFunctionStyle::SFS_Empty;
----------------
djasper wrote:
> I'd prefer these functions not to be in the public header file. They are implementation details. Either find a header/cpp-file in the lib/ directory to place them in or just remove them for now. They are both still quite small and called only twice each.
This is similar to the isCpp() method, to provide a better abstraction in the implementation.
I cannot find any better place, so I will remove them.


https://reviews.llvm.org/D34399





More information about the cfe-commits mailing list