[PATCH] D34329: [GSoC] Clang AST diffing

[Manuel Klimek via Phabricator via cfe-commits]

klimek added a comment.

Reviewing this mainly from the API view, and leaving the technical details to others :)



================
Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:124
+
+class ASTDiff {
+  TreeRoot &T1, &T2;
----------------
Generally, can we put the public interface first in the class?
Usually folks read a source file top-down, so if the most relevant pieces of code are at the top, the source file gets easier to read and understand.

Thus:
1. try to keep clutter (like classes and typedefs not used by a user of the API) in a different header, or forward declare them and define them in the .cpp file
2. sort things into public first, then private in classes.


https://reviews.llvm.org/D34329