[PATCH] D34329: [GSoC] Clang AST diffing

[Johannes Altmanninger via Phabricator via cfe-commits]

johannes marked 10 inline comments as done.
johannes added inline comments.


================
Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:123
+
+void runDiff(ASTContext &AST1, ASTContext &AST2);
+
----------------
klimek wrote:
> This is the main exposed interface?
> 
> Generally, if all we want to do is printing, I wouldn't put that into a library in Tooling, but just implement a tools/ASTDiffer or somesuch.
> 
> If you want to make this a library, it should return the diff in some form that's nice to use (or print).
> 
I started out by creating a self contained tool, that's why the interface does not really make sense.

I will change it to provide the mappings and the edit script in a nice way, this might be quite useful.


https://reviews.llvm.org/D34329