[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

[Ben Langmuir via Phabricator via cfe-commits]

benlangmuir added a comment.

Thanks, this looks good to me.  I'd appreciate if @klimek could take a quick look though.



================
Comment at: include/clang/Lex/PreprocessorOptions.h:102
+  /// in preprocessor directive conditions it causes all blocks to be parsed so
+  /// that the client can get the max amount of info from the parser.
   bool SingleFileParseMode = false;
----------------
nitpick: should use the full words "maximum" and probably also "information" here


https://reviews.llvm.org/D34263