[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports
Sean Callanan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 16 11:11:17 PDT 2017
spyffe added a comment.
Hmm, the transforming in place of `SelLocs` reads a little weirdly to me, but other than that the code seems fine.
Is your concern that you don't know how to write an Objective-C test that would cover this? It looks to me like an Objective-C interface with a method:
@interface MyClass { }
-(int)addInt:(int)a toInt:(int)b moduloInt:(int)c;
@end
might be enough for an ASTMerge test. If you want to make `clang-import-test` use this code, then we might need to add one or two things into that tester to handle Objective-C method lookup.
https://reviews.llvm.org/D6550
More information about the cfe-commits
mailing list