[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 15 21:38:41 PDT 2017


EricWF added inline comments.


================
Comment at: src/experimental/filesystem/operations.cpp:22-24
+#if defined(__APPLE__)
+#include <Availability.h>
+#endif
----------------
dexonsmith wrote:
> I only just noticed you were including Availability.h.  That shouldn't be necessary, since the macros should be defined by the compiler.
__MAC_10_13 et al are defined in `Availability.h`, and `AvailabilityInternal.h` seems to do the `__ENV` dance described above. Are you sure it's not needed?


https://reviews.llvm.org/D34249





More information about the cfe-commits mailing list