[PATCH] D34268: [clang] Fix format specifiers fixits for nested macros

[Mehdi AMINI via Phabricator via cfe-commits]

mehdi_amini added a comment.

Thanks for fixing! (I'm still not the best qualified to review this)



================
Comment at: lib/Edit/EditedSource.cpp:78
     if (I != ExpansionToArgMap.end() &&
-        std::find_if(
-            I->second.begin(), I->second.end(), [&](const MacroArgUse &U) {
-              return ArgUse.first == U.first && ArgUse.second != U.second;
-            }) != I->second.end()) {
+        std::find_if(I->second.begin(), I->second.end(),
+                     [&](const MacroArgUse &U) {
----------------
Nit: `llvm::find_if` allows to skip begin/end as `llvm::find_if(I->second, [] ...`


================
Comment at: test/FixIt/fixit-format-darwin.m:71
+
+void radar33447() {
+  Outer2("test 8: %s", getNSInteger());  
----------------
I think you mean `pr` instead of `radar` ;)


Repository:
  rL LLVM

https://reviews.llvm.org/D34268