[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude <stdc-predef.h>

[Melanie Blower via Phabricator via cfe-commits]

mibintc updated this revision to Diff 102605.
mibintc added a comment.

Thanks for your review, Fedor.  I moved AddGnuIncludeArgs out of GCCInstallation, like you suggested, and put it along where the library includes are added.  I also pulled out the change for MipsLinux since I don't have a way to verify that.

I still have the same 7 test failures when make check-all on Linux. 3 of the fails are from "clangd" unit tests. Not sure why they are failing but i scanned the tests a little and it talks about access only to whitelisted directories, so I assume they aren't working because the dir where std-predef.h lives is not white listed. Maybe I should be sure that "file exists(stdc-predef.h)", e.g. using the system include path, before adding the -include into the command line--what do you think?


Repository:
  rL LLVM

https://reviews.llvm.org/D34158

Files:
  include/clang/Driver/ToolChain.h
  lib/Driver/ToolChain.cpp
  lib/Driver/ToolChains/Gnu.cpp
  lib/Driver/ToolChains/Gnu.h
  lib/Driver/ToolChains/Linux.cpp
  lib/Driver/ToolChains/Linux.h
  test/Driver/clang_cpp.c
  test/Driver/gcc-predef.c
  test/Index/IBOutletCollection.m
  test/Index/annotate-macro-args.m
  test/Index/annotate-tokens-pp.c
  test/Index/annotate-tokens.c
  test/Index/c-index-getCursor-test.m
  test/Index/get-cursor-macro-args.m
  test/Index/get-cursor.cpp
  unittests/Tooling/TestVisitor.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34158.102605.patch
Type: text/x-patch
Size: 23977 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170614/868f3553/attachment-0001.bin>