[PATCH] D32046: [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments, correct getNumArguments

[Alex Lorenz via Phabricator via cfe-commits]

arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.

LGTM! Please fix the code style issues that I pointed out before committing.



================
Comment at: unittests/Lex/LexerTest.cpp:24
 #include "clang/Lex/PreprocessorOptions.h"
+#include "clang/Lex/MacroArgs.h"
+#include "clang/Lex/MacroInfo.h"
----------------
Please put these two new includes before `#include "clang/Lex/ModuleLoader.h"`


================
Comment at: unittests/Lex/LexerTest.cpp:46
 
-  std::vector<Token> Lex(StringRef Source) {
+  std::unique_ptr<Preprocessor> CreatePP(StringRef Source, TrivialModuleLoader& ModLoader) {
     std::unique_ptr<llvm::MemoryBuffer> Buf =
----------------
I think this violates the 80 columns, please reformat this declaration.


================
Comment at: unittests/Lex/LexerTest.cpp:62
+    return PP;
+  }
+  std::vector<Token> Lex(StringRef Source) {
----------------
NIT: Please add a new line after '}'.


https://reviews.llvm.org/D32046