[PATCH] D34202: [clang-tidy] readability-function-size: fix nesting level calculation
Malcolm Parsons via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 14 06:46:22 PDT 2017
malcolm.parsons added inline comments.
================
Comment at: clang-tidy/readability/FunctionSizeCheck.cpp:38
+ } else {
+ assert(!isa<CompoundStmt>(Node));
+ if (TrackedParent.back())
----------------
I don't think this assert adds anything.
================
Comment at: clang-tidy/readability/FunctionSizeCheck.cpp:62
- if (TrackedParent.back())
+ // did we just process CompoundStmt? if yes, decrease current nesting level.
+ if (isa<CompoundStmt>(Node))
----------------
Comments are sentences, so start with a capital letter.
Repository:
rL LLVM
https://reviews.llvm.org/D34202
More information about the cfe-commits
mailing list