[PATCH] D34170: [libcxx] Moving compiler specific test infrastructure to compiler.py

Ben Craig via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 13 13:53:52 PDT 2017


bcraig created this revision.

format.py and config.py were routinely reaching into the innards of compiler.py, then setting variables in a very gcc / clang-centric way.  Now, all the compiler specific code has been moved to compiler.py.  These makes it possible to (in theory) build with MSVC instead, by switching to a different CXXCompilerInterface implementation.

This refactor did not attempt to make large, simplifying changes.  It is mainly moving code to the right place so that later work can consolidate and clean as needed.

As a proof of concept, I was able to switch out CXXCompilerInterface implementations and run the libc++ tests with MSVC 2017 and the MSVC 2017 STL, with 3486/5472 passing (I didn't dive into the failure cases).  The MSVC test infrastructure port is not included in this review.


https://reviews.llvm.org/D34170

Files:
  utils/libcxx/compiler.py
  utils/libcxx/test/config.py
  utils/libcxx/test/format.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34170.102398.patch
Type: text/x-patch
Size: 81995 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170613/9decbc70/attachment-0001.bin>


More information about the cfe-commits mailing list