D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude <stdc-predef.h>

Blower, Melanie via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 13 12:34:11 PDT 2017


Thanks I'll fix that. 

-----Original Message-----
From: Fedor Sergeev via Phabricator [mailto:reviews at reviews.llvm.org] 
Sent: Tuesday, June 13, 2017 3:30 PM
To: Blower, Melanie <melanie.blower at intel.com>; zhangshengbin at huawei.com; olivier.jg at gmail.com; kalinichev.so.0 at gmail.com; kfunk at kde.org; mail at milianw.de; cfe-commits at lists.llvm.org; Keane, Erich <erich.keane at intel.com>
Cc: klimek at google.com; simon.dardis at imgtec.com; anastasia.stulova at arm.com; arichardson.kde at gmail.com; fedor.sergeev at oracle.com
Subject: [PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude <stdc-predef.h>

fedor.sergeev added a comment.

There is no /usr/include/stdc-predef.h on Solaris and I see no sense in adding this -include for anything except Linux (as docs are rather clear that this functionality is Linux-only).

Checked gcc on Solaris11/12 both SPARC and X86 - none are doing stdc-predef.h inclusion (checking with

  gcc  - -dI </dev/null -E | grep stdc-predef

)


https://reviews.llvm.org/D34158





More information about the cfe-commits mailing list