[PATCH] D33852: Enable __declspec(selectany) on linux

[Reid Kleckner via Phabricator via cfe-commits]

rnk added inline comments.


================
Comment at: include/clang/Basic/Attr.td:2421
 
-def SelectAny : InheritableAttr, TargetSpecificAttr<TargetWindows> {
+def SelectAny : InheritableAttr, TargetSpecificAttr<TargetWindowsAndLinux> {
   let Spellings = [Declspec<"selectany">, GCC<"selectany">];
----------------
davide wrote:
> Prazek wrote:
> > majnemer wrote:
> > > selectany should work on targets other than "x86", "x86_64", "arm", "thumb", etc. I think it is only necessary to require that it be a COFF or ELF target.
> > Should we allow other OSes than Win32 and Linux?
> I guess everything ELF should be allowed.
Why not use weak_odr / linkonce_odr on MachO? Microsoft builds Office for Mac and I suspect they use `__declspec(selectany)`.


https://reviews.llvm.org/D33852