[PATCH] D33910: [ubsan] Detect invalid unsigned pointer index expression (clang)

[Will Dietz via Phabricator via cfe-commits]

dtzWill accepted this revision.
dtzWill added a comment.

LGTM!

Sorry for missing this originally, as a perhaps interesting note:
the checks were extracted from a research prototype that worked at the IR level --where pointer itself is unsigned but the offsets (including the computed total offset) is a signed expression[1].
(we also tracked conversions and whatnot, so... well things were different.  Anyway, sorry for missing this!)

This looks great to me, thanks for identifying this and putting it together!

[1] http://llvm.org/docs/GetElementPtr.html#what-happens-if-a-gep-computation-overflows


https://reviews.llvm.org/D33910