[PATCH] D16717: [clang-tidy] Add non-constant references in function parameters check.

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 9 11:23:31 PDT 2017


lebedev.ri added a comment.

  // Don't warn on dependent types in templates.

Hmm, i wanted to try to fix my Bug 32683 <https://bugs.llvm.org/show_bug.cgi?id=32683>  about templated references being ignored, and i found out that it is actually intentional...
Reading https://google.github.io/styleguide/cppguide.html#Reference_Arguments i do not see why non-const `T &` should be ignored.
Is there a reason for this? Or perhaps, looking at the `g9()`/`g10()`, this implicit whitelisting should be more fine-grained, specific?


Repository:
  rL LLVM

https://reviews.llvm.org/D16717





More information about the cfe-commits mailing list