[PATCH] D34033: [clangd] Add parameter and return type information to completion results

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov accepted this revision.
ilya-biryukov added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/clangd/completion.test:32
 # CHECK: {"jsonrpc":"2.0","id":1,"result":[
-# CHECK-DAG: {"label":"a","kind":5}
-# CHECK-DAG: {"label":"bb","kind":5}
-# CHECK-DAG: {"label":"ccc","kind":5}
+# CHECK-DAG: {"label":"a","kind":5,"detail":"int","insertText":"a"}
 # CHECK: ]}
----------------
krasimir wrote:
> ilya-biryukov wrote:
> > Should we repeat repeat the checks added above here too?
> This test case is about understanding 'file:/main.cpp', so I don't think repeating everything would be beneficial.
Makes sense.
Testing that the output is the same on repeated runs of completion wouldn't probably hurt either.
But if you feel it makes tests too clunky, let's not have it here.


https://reviews.llvm.org/D34033