[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 7 11:47:23 PDT 2017


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Aside from one minor nit, LGTM



================
Comment at: clang-tidy/misc/NoexceptMoveConstructorCheck.cpp:23
   // provide any benefit to other languages, despite being benign.
-  if (!getLangOpts().CPlusPlus11)
+  if ((!getLangOpts().CPlusPlus11) || (!getLangOpts().CXXExceptions))
     return;
----------------
You can remove the spurious parens.


Repository:
  rL LLVM

https://reviews.llvm.org/D34002





More information about the cfe-commits mailing list