[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

[Alexey Bataev via Phabricator via cfe-commits]

ABataev marked 7 inline comments as done.
ABataev added inline comments.


================
Comment at: include/clang/AST/Decl.h:1387
+    IPK_CapturedContext, /// Parameter for captured context
+    IPK_GeneralParam,    /// General implicit parameter
+  };
----------------
rjmccall wrote:
> I would just call this "Other" and document it as being for kinds of implicit parameters that we haven't seen a purpose in categorizing yet.  (Or you could just classify them all, I suppose.)
> 
> We can use C++11 features in Clang now, so I would recommend hoisting this type out of ImplicitParamDecl and making it an enum class.  You can then drop the "IPK_" prefixes.
It's hard to classify them, in most cases they just represent some general parameters used for correct codegen of function types and that's it.


https://reviews.llvm.org/D33735