[PATCH] D33875: PR27037: Use correct CVR qualifier on an upcast on method pointer call

[Taiju Tsuiki via Phabricator via cfe-commits]

tzik updated this revision to Diff 101536.
tzik added a comment.

Cover indirect case and non-CVR qualifiers


https://reviews.llvm.org/D33875

Files:
  lib/Sema/SemaExprCXX.cpp
  test/SemaCXX/PR27037.cpp


Index: test/SemaCXX/PR27037.cpp
===================================================================
--- /dev/null
+++ test/SemaCXX/PR27037.cpp
@@ -0,0 +1,13 @@
+// RUN: %clang_cc1 -fsyntax-only -verify %s
+
+struct A {
+  void f();
+};
+
+struct B : A {};
+
+void m() {
+  const B b;
+  (b.*&B::f)();  // expected-error{{drops 'const' qualifier}}
+  ((&b)->*&B::f)();  // expected-error{{drops 'const' qualifier}}
+}
Index: lib/Sema/SemaExprCXX.cpp
===================================================================
--- lib/Sema/SemaExprCXX.cpp
+++ lib/Sema/SemaExprCXX.cpp
@@ -5104,7 +5104,9 @@
       return QualType();
 
     // Cast LHS to type of use.
-    QualType UseType = isIndirect ? Context.getPointerType(Class) : Class;
+    QualType UseType = Context.getQualifiedType(Class, LHSType.getQualifiers());
+    if (isIndirect)
+      UseType = Context.getPointerType(UseType);
     ExprValueKind VK = isIndirect ? VK_RValue : LHS.get()->getValueKind();
     LHS = ImpCastExprToType(LHS.get(), UseType, CK_DerivedToBase, VK,
                             &BasePath);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33875.101536.patch
Type: text/x-patch
Size: 1075 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170606/5d076a93/attachment-0001.bin>