[PATCH] D33820: [PowerPC] Pass CPU to assembler with -no-integrated-as

Eric Christopher via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 5 15:44:18 PDT 2017


echristo added a comment.

One inline comment otherwise LGTM



================
Comment at: lib/Driver/ToolChains/Gnu.cpp:681
     CmdArgs.push_back("-mppc");
-    CmdArgs.push_back("-many");
+    std::string CPU = getCPUName(Args, getToolChain().getTriple());
+    CmdArgs.push_back(ppc::getPPCAsmModeForCPU(CPU));
----------------
Probably don't need to store it to a temporary since the other function is just returning a const char *.


Repository:
  rL LLVM

https://reviews.llvm.org/D33820





More information about the cfe-commits mailing list