ahatanak added inline comments. ================ Comment at: lib/Basic/Targets.cpp:5444 + Feature = "-thumb-mode"; + if (Feature.compare("+thumb") == 0) + Feature = "+thumb-mode"; ---------------- This can be "else if". https://reviews.llvm.org/D33721