[PATCH] D33841: [clang-tidy] redundant keyword check

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 2 16:26:24 PDT 2017


Eugene.Zelenko added a comment.

Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).



================
Comment at: docs/clang-tidy/checks/readability-redundant-keyword.rst:6
+
+This checker removes the redundant `extern` and `inline` keywords from code.
+
----------------
checker -> check. Please use `` to highlight language constructs here and below.


================
Comment at: docs/clang-tidy/checks/readability-redundant-keyword.rst:13
+  extern void h();
+
+
----------------
Unnecessary empty line.


================
Comment at: docs/clang-tidy/checks/readability-redundant-keyword.rst:20
+  class X {
+    inline int f() { .... }
+  };
----------------
May be three dots will be better as common punctuation?


================
Comment at: docs/clang-tidy/checks/readability-redundant-keyword.rst:22
+  };
\ No newline at end of file

----------------
Please add newline.


Repository:
  rL LLVM

https://reviews.llvm.org/D33841





More information about the cfe-commits mailing list