[libcxx] r304591 - Mark two coroutine tests as unsupported under ubsan, again

[Vedant Kumar via cfe-commits]

Hi Gor,

This is just a heads-up that I tried re-enabling ubsan for the two tests affected by PR33271, but saw some similar failures. The commit message below has more details about what was tested and what went wrong.

best,
vedant


> On Jun 2, 2017, at 1:06 PM, Vedant Kumar via cfe-commits <cfe-commits at lists.llvm.org> wrote:
> 
> Author: vedantk
> Date: Fri Jun  2 15:06:49 2017
> New Revision: 304591
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=304591&view=rev
> Log:
> Mark two coroutine tests as unsupported under ubsan, again
> 
> This reverts commit r304580, making bool_await_suspend.pass.cpp and
> generator.pass.cpp unsupported on ubsan again. The host compiler is
> based on r304329, which has the change from PR33271 (r304277). However,
> this was not enough to address the issue.
> 
> Bot Failure:
> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-ubsan/builds/628
> 
> Unknown type!
> UNREACHABLE executed at /home/eric/full-llvm/llvm/lib/IR/ValueTypes.cpp:287!
> llvm::EVT::getEVT(llvm::Type*, bool) (/usr/local/bin/clang-5.0+0x17e7a07)
> llvm::TargetLoweringBase::getValueType(llvm::DataLayout const&, llvm::Type*, bool) const (/usr/local/bin/clang-5.0+0x852c4a)
> llvm::ComputeValueVTs(llvm::TargetLowering const&, llvm::DataLayout const&, llvm::Type*, llvm::SmallVectorImpl<llvm::EVT>&, llvm::SmallVectorImpl<unsigned long>*, unsigned long) (/usr/local/bin/clang-5.0+0x141b6e9)
> llvm::SelectionDAGBuilder::visitTargetIntrinsic(llvm::CallInst const&, unsigned int) (/usr/local/bin/clang-5.0+0x237b1ca)
> 
> clang-5.0: /home/eric/full-llvm/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1236: virtual void llvm::DwarfDebug::endFunctionImpl(const llvm::MachineFunction *): Assertion `LScopes.getAbstractScopesList().size() == NumAbstractScopes && "ensureAbstractVariableIsCreated inserted abstract scopes"' failed.
> __assert_fail_base /build/glibc-9tT8Do/glibc-2.23/assert/assert.c:92:0
> (/lib/x86_64-linux-gnu/libc.so.6+0x2dc82)
> llvm::DwarfDebug::endFunctionImpl(llvm::MachineFunction const*) (/usr/local/bin/clang-5.0+0x223f86b)
> llvm::DebugHandlerBase::endFunction(llvm::MachineFunction const*) (/usr/local/bin/clang-5.0+0x227a5a1)
> llvm::AsmPrinter::EmitFunctionBody() (/usr/local/bin/clang-5.0+0x222522f)
> 
> Modified:
>    libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/bool_await_suspend.pass.cpp
>    libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/generator.pass.cpp
> 
> Modified: libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/bool_await_suspend.pass.cpp
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/bool_await_suspend.pass.cpp?rev=304591&r1=304590&r2=304591&view=diff
> ==============================================================================
> --- libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/bool_await_suspend.pass.cpp (original)
> +++ libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/bool_await_suspend.pass.cpp Fri Jun  2 15:06:49 2017
> @@ -10,6 +10,9 @@
> 
> // UNSUPPORTED: c++98, c++03, c++11
> 
> +// See https://bugs.llvm.org/show_bug.cgi?id=33271
> +// UNSUPPORTED: ubsan
> +
> #include <experimental/coroutine>
> #include <cassert>
> 
> 
> Modified: libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/generator.pass.cpp
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/generator.pass.cpp?rev=304591&r1=304590&r2=304591&view=diff
> ==============================================================================
> --- libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/generator.pass.cpp (original)
> +++ libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/generator.pass.cpp Fri Jun  2 15:06:49 2017
> @@ -10,6 +10,9 @@
> 
> // UNSUPPORTED: c++98, c++03, c++11
> 
> +// See https://bugs.llvm.org/show_bug.cgi?id=33271
> +// UNSUPPORTED: ubsan
> +
> #include <experimental/coroutine>
> #include <vector>
> #include <cassert>
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits