[PATCH] D33825: [clang-tidy] signal handler must be plain old function check

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tidy/cert/CERTTidyModule.cpp:64
+        "cert-msc54-cpp");
     // C checkers
     // DCL
----------------
checker -> check.


================
Comment at: docs/ReleaseNotes.rst:73
+
+  Checks if a signal handler is not a plain old function.
+
----------------
Probably C++ should be mentioned for clarity.


================
Comment at: docs/clang-tidy/checks/cert-msc54-cpp.rst:7
+This check will give a warning if a signal handler is not defined
+as an 'extern C' function or if the declaration of the function
+contains C++ representation.
----------------
'extern C' -> ``extern "C"``.


================
Comment at: docs/clang-tidy/checks/cert-msc54-cpp.rst:21
+    }
+
+
----------------
Unnecessary empty line.


================
Comment at: docs/clang-tidy/checks/cert-msc54-cpp.rst:32
+    }
+
+
----------------
Unnecessary empty line.


================
Comment at: docs/clang-tidy/checks/cert-msc54-cpp.rst:34
+
+This check corresponds to the CERT CPP Coding Standard rule
+`MSC54-CPP. A signal handler must be a plain old function
----------------
Please replace CPP with C++ as in similar checks documentation.


Repository:
  rL LLVM

https://reviews.llvm.org/D33825