[PATCH] D33102: [clang] Implement -Wcast-qual for C++

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 2 09:52:09 PDT 2017


lebedev.ri added a comment.

In https://reviews.llvm.org/D33102#767291, @dblaikie wrote:

> Still seems like an awful lot more testing than I'd  expect for this warning. (eg: testing all the many variations of C++ const_cast - when they all provide basically the same coverage I think, that all const_casts don't warn)


Ok, i removed a bit more of const_cast checks, but unless you insist, i'd think all the rest of the test are needed :)
I do understand that it is ideal to keep the checks as small as possible for speed reasons.


Repository:
  rL LLVM

https://reviews.llvm.org/D33102





More information about the cfe-commits mailing list