[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier
Jennifer Yu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 2 09:00:39 PDT 2017
jyu2 marked 2 inline comments as done.
jyu2 added inline comments.
================
Comment at: lib/Sema/AnalysisBasedWarnings.cpp:334
+ continue;
+ else
+ HasThrowOutFunc = true;
----------------
jyu2 wrote:
> aaron.ballman wrote:
> > You can drop the `else` here and just set `HasThrowOutFunc` to true.
> Can not do that, don't if block has throw expression yet.
Yes, Eric just point out, you are right, I can remove the line of "else"
https://reviews.llvm.org/D33333
More information about the cfe-commits
mailing list