[PATCH] D33537: [clang-tidy] Exception Escape Checker

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 2 05:34:11 PDT 2017


aaron.ballman added a comment.

In https://reviews.llvm.org/D33537#771159, @baloghadamsoftware wrote:

> In https://reviews.llvm.org/D33537#770264, @aaron.ballman wrote:
>
> > I think we should try to get as much of this functionality in https://reviews.llvm.org/D33333 as possible; there is a considerable amount of overlap between that functionality and this functionality. This check can then cover only the parts that are not reasonably handled by the frontend check instead of duplicating diagnostics the user already receives.
>
>
> I suppose that the frontend check will not travarse the call-graph just check direct throws. Should we only check indirect throws then?


The check in https://reviews.llvm.org/D33333 is using a CFG, not just checking direct throws.


https://reviews.llvm.org/D33537





More information about the cfe-commits mailing list