[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it
Keno Fischer via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 1 13:16:19 PDT 2017
loladiro added a comment.
There's already such a test case, but the cloning currently doesn't assert properly (but it can generate incorrect code). https://reviews.llvm.org/D33655 fixes that up, so I think the testing is covered once that LLVM commit goes in. I'll hold off a little while to give @aprantl a chance to look at this as well, but I do want to get this in in short order, so I can recommit https://reviews.llvm.org/D33655.
https://reviews.llvm.org/D33705
More information about the cfe-commits
mailing list