r304380 - CGCleanup: (NFC) add another test for r304335 - Don't try to spill static allocas

Gor Nishanov via cfe-commits cfe-commits at lists.llvm.org
Wed May 31 18:15:25 PDT 2017


Author: gornishanov
Date: Wed May 31 20:15:25 2017
New Revision: 304380

URL: http://llvm.org/viewvc/llvm-project?rev=304380&view=rev
Log:
CGCleanup: (NFC) add another test for r304335 - Don't try to spill static allocas

Summary:
Coroutine related test that used to trigger broken IR prior to r304335.

```
%x = alloca i32, align 4
store i32* %x, i32** %tmp.exprcleanup, align 4 ; <===== HERE
%ref.tmp3 = alloca %struct.A, align 1
%agg.tmp5 = alloca %"struct.std::experimental::coroutines_v1::coroutine_handle.0", align 4
%tmp.exprcleanup = alloca i32*, align 4
%allocapt = bitcast i32 undef to i32
store i32 %0, i32* %.addr, align 4
```

Fixed with r304335

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D33750

Added:
    cfe/trunk/test/CodeGenCoroutines/coro-await-domination.cpp

Added: cfe/trunk/test/CodeGenCoroutines/coro-await-domination.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCoroutines/coro-await-domination.cpp?rev=304380&view=auto
==============================================================================
--- cfe/trunk/test/CodeGenCoroutines/coro-await-domination.cpp (added)
+++ cfe/trunk/test/CodeGenCoroutines/coro-await-domination.cpp Wed May 31 20:15:25 2017
@@ -0,0 +1,38 @@
+// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fcoroutines-ts -std=c++14 -emit-llvm %s -o - | FileCheck %s
+#include "Inputs/coroutine.h"
+
+using namespace std::experimental;
+
+struct coro {
+  struct promise_type {
+    coro get_return_object();
+    suspend_never initial_suspend();
+    suspend_never final_suspend();
+    void return_void();
+    static void unhandled_exception();
+  };
+};
+
+struct A {
+  ~A();
+  bool await_ready();
+  int await_resume() { return 8; }
+  template <typename F> void await_suspend(F);
+};
+
+extern "C" void consume(int);
+
+// Verifies that domination is properly built during cleanup.
+// Without CGCleanup.cpp fix verifier was reporting:
+// Instruction does not dominate all uses!
+//  %tmp.exprcleanup = alloca i32*, align 8
+//  store i32* %x, i32** %tmp.exprcleanup, align 8
+
+
+// CHECK-LABEL: f(
+extern "C" coro f(int) {
+  int x = 42;
+  x = co_await A{};
+  consume(x);
+}
+




More information about the cfe-commits mailing list