[PATCH] D31830: Emit invariant.group.barrier when using union field
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 31 18:01:50 PDT 2017
rjmccall added inline comments.
================
Comment at: test/CodeGenCXX/strict-vtable-pointers.cpp:263
+
+struct VirtualInVBase : virtual Empty, HoldingVirtuals {
+};
----------------
"virtual" applies to an individual base, not to all following bases. You need "virtual HoldingVirtuals" here.
Although, come to think of it, having a virtual base should already ensure that the class has a v-table, even if it has no other reason for one. (You should add a test for that!)
https://reviews.llvm.org/D31830
More information about the cfe-commits
mailing list