[PATCH] D33741: [libc++] Undef min/max in test_macros.h

Stephan T. Lavavej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 31 16:00:32 PDT 2017


STL_MSFT added a comment.

I haven't seen min/max test failures, probably because our CRT/STL headers never drag in Windows.h.

I have no objection to undeffing min/max although I wouldn't do this myself (it creates order dependencies which I think are totally evil).


https://reviews.llvm.org/D33741





More information about the cfe-commits mailing list