[PATCH] D33733: CGCleanup: No need to do domination fixups for static allocas

[Reid Kleckner via Phabricator via cfe-commits]

rnk added inline comments.


================
Comment at: test/CodeGenCoroutines/coro-await-domination.cpp:33
+  int x = 42;
+  x = co_await A{};
+}
----------------
It looks like this is the expression in question. This expression should have aggregate evaluation kind, not scalar. We don't need to reload aggregate expression evaluation results because they are represented with temporary allocas, and they don't have dominance problems. It seems like there is an incorrect call to PopCleanupBlocks somewhere, and that's where the real fix should be.


https://reviews.llvm.org/D33733