[PATCH] D32595: CMakeLists: Don't set LLVM_MAIN_SRC_DIR when building stand-alone clang

[Chris Bieneman via Phabricator via cfe-commits]

beanz added a comment.

Is this really something we should be supporting? Building and testing clang with potentially out-of-sync lit or gtest seems undesirable to me.

It is worth noting that we do have mods to gtest, so supporting any standard distribution of it seems like a not great idea. The general approach in the past for standalone builds has been to disable testing unless an LLVM source tree is available, and I think that might be the right approach.

Also, this all kinda becomes moot if LLVM moves to a mono-repo (really not trying to troll here), because people actively developing LLVM projects will basically be forced to have LLVM source trees anyways.

Thoughts?


https://reviews.llvm.org/D32595