[PATCH] D33711: [TableGen] Clang changes to support Record::getValueAsString and getValueAsListOfStrings returning StringRef instead of std::string

Matthias Braun via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 31 10:23:24 PDT 2017


MatzeB accepted this revision.
MatzeB added a comment.

I assume you have checked that the tablegen output doesn't change. Apart from that I'm all for more StringRef and SmallStrings or even Twines where possible. So LGTM.


https://reviews.llvm.org/D33711





More information about the cfe-commits mailing list