[PATCH] D33616: [MS] Fix _bittest* intrinsics for values bigger than 31

David Majnemer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 30 16:09:53 PDT 2017


majnemer added a comment.

In https://reviews.llvm.org/D33616#768287, @hans wrote:

> From looking in the Intel manual (Table 3-2, in 3.1.1.9 about Bit(BitBase,BitOffset)) it does sound like the bit offset can be negative *shudder*, so I suppose this is necessary and explains why the type is signed in the first place? Hopefully most of these will be inlined into a context where BitPos is constant or unsigned.


Indeed :/


https://reviews.llvm.org/D33616





More information about the cfe-commits mailing list