[PATCH] D33304: [clang-tidy] Add a new module Android and a new check for file descriptors.

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang-tidy/utils/ExprToStr.cpp:23
+                     SM.getCharacterData(TE) - SM.getCharacterData(B));
+}
+} // namespace utils
----------------
Please add empty line.


================
Comment at: clang-tidy/utils/ExprToStr.h:22
+std::string ExprToStr(const Expr *EX, const SourceManager &SM,
+                      const LangOptions &LangOpts);
+} // namespace utils
----------------
Please add empty line.


================
Comment at: docs/ReleaseNotes.rst:69
+
+  Checks if any usage of function ``creat()``.
+
----------------
May be detect usage of ``creat()`` will be better?


================
Comment at: docs/clang-tidy/checks/android-creat-usage.rst:5
+===========================
+The usage of creat() is not recommended, it's better to use open().
----------------
Please enclose creat() and open() in `` and add empty line before.


================
Comment at: docs/clang-tidy/checks/android-file-open-flag.rst:5
+==============================
+A common source of security bugs has been code that opens file without using
+the ``O_CLOEXEC`` flag.  Without that flag, an opened sensitive file would
----------------
Please add empty line.


================
Comment at: docs/clang-tidy/checks/android-file-open-flag.rst:10
+``open64()`` must include ``O_CLOEXEC`` in their flags argument.
+
+
----------------
Unnecessary empty line.


================
Comment at: docs/clang-tidy/checks/android-fopen-mode.rst:5
+=========================
+``fopen()`` should include ``e`` in their mode string; so ``re`` would be
+valid.
----------------
Please add empty line.


https://reviews.llvm.org/D33304