[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

Mateusz Belicki via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 30 01:26:36 PDT 2017


belickim added inline comments.


================
Comment at: include/clang/Basic/TargetBuiltins.h:154
+  /// \brief Nios2 builtins
+  namespace Nios2 {
+      enum {
----------------
ahatanak wrote:
> No need to indent enum inside namespace.
> 
> http://llvm.org/docs/CodingStandards.html#namespace-indentation
I was trying to follow conventions used by other code in this file (this also applies to some extend to other things that you pointed out). I will try to follow LLVM coding conventions over style present in file for any future changes. Thank you for your comments, I will prepare update with all changes that you suggested.


https://reviews.llvm.org/D33356





More information about the cfe-commits mailing list