[PATCH] D33437: Emit available_externally vtables opportunistically

[David Blaikie via Phabricator via cfe-commits]

dblaikie added inline comments.


================
Comment at: lib/CodeGen/CodeGenModule.cpp:1383-1385
+  if (!OpportunisticVTables.empty())
+    assert(shouldOpportunisticallyEmitVTables() &&
+           "Only emit opportunistic vtables with optimizations");
----------------
Perhaps this:
  assert(OpportunisticVTables.empty() || shouldOpportunisticallyEmitVTables() && ... )

(it's a bit odd to have a condition that only goes to an assert - rather than having both conditions inside the assertion)


https://reviews.llvm.org/D33437