[PATCH] D33437: Emit available_externally vtables opportunistically

[Piotr Padlewski via Phabricator via cfe-commits]

Prazek marked an inline comment as done.
Prazek added inline comments.


================
Comment at: include/clang/AST/VTableBuilder.h:169
+      return GlobalDecl(DtorDecl, CXXDtorType::Dtor_Deleting);
+    default:
+      llvm_unreachable("Only function pointers kinds");
----------------
rjmccall wrote:
> By "exhaustive" I mean that you should list out all the cases instead of using default.  It means that someone who adds a new kind of v-table entry will get alerted to fix this switch.  There's only five other cases, it's not too bad.
Oh right, that make sense


https://reviews.llvm.org/D33437