[PATCH] D33537: [clang-tidy] Exception Escape Checker

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 25 10:14:53 PDT 2017


Eugene.Zelenko added a comment.

Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).



================
Comment at: docs/clang-tidy/checks/misc-exception-escape.rst:7
+Finds functions which should not throw exceptions:
++ Destructors
++ Copy constructors
----------------
I think - or * is more correct.


================
Comment at: docs/clang-tidy/checks/misc-exception-escape.rst:10
++ Copy assignment operators
++ The main() functions
++ swap() functions
----------------
Please enclose main() in ``. Same for other functions and keywords.


================
Comment at: docs/clang-tidy/checks/misc-exception-escape.rst:29
+   Comma separated list containing function names which should not throw. An
+   example for using this parameter is the function WinMain in the Windows API.
+   Default vale is empty string.
----------------
Please add () to WinMain and enclose it in ``.


================
Comment at: docs/clang-tidy/checks/misc-exception-escape.rst:35
+   Comma separated list containing type names which are not counted as thrown
+   exceptions in the checker. Default value is empty string.
----------------
Please use check instead of checker.


https://reviews.llvm.org/D33537





More information about the cfe-commits mailing list