[PATCH] D33406: PR28129 expand vector oparation to an IR constant.

[Dinar Temirbulatov via Phabricator via cfe-commits]

dtemirbulatov added a comment.

> Should we handle the 'pd256' version the same way?
> How about the 0xb ('false') constant? It should produce a zero here?
> Can or should we deal with the signalling versions (0x1b, 0x1f) too?

hm looks like 0xb(_CMP_FALSE_OQ) is ordered, so it is not possible and 0x1b or 0x1f might emit a signal.



================
Comment at: lib/CodeGen/CGBuiltin.cpp:7932
       break;
     case X86::BI__builtin_ia32_cmppd256:
       ID = Intrinsic::x86_avx_cmp_pd_256;
----------------
spatel wrote:
> 1. Should we handle the 'pd256' version the same way?
> 2. How about the 0xb ('false') constant? It should produce a zero here?
> 3. Can or should we deal with the signalling versions (0x1b, 0x1f) too?
> 
hm looks like 0xb(_CMP_FALSE_OQ) is ordered, so it is not possible and 0x1b or 0x1f might emit a signal.


https://reviews.llvm.org/D33406