[PATCH] D33357: Avoid calling report_fatal_error in the destructor of raw_fd_ostream when saving a module timestamp file

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 23 06:50:59 PDT 2017


arphaman updated this revision to Diff 99904.
arphaman added a comment.

Remove the first redundant error check.


Repository:
  rL LLVM

https://reviews.llvm.org/D33357

Files:
  lib/Serialization/ASTReader.cpp


Index: lib/Serialization/ASTReader.cpp
===================================================================
--- lib/Serialization/ASTReader.cpp
+++ lib/Serialization/ASTReader.cpp
@@ -3655,6 +3655,8 @@
   if (EC)
     return;
   OS << "Timestamp file\n";
+  OS.close();
+  OS.clear_error(); // Avoid triggering a fatal error.
 }
 
 /// \brief Given a cursor at the start of an AST file, scan ahead and drop the


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33357.99904.patch
Type: text/x-patch
Size: 410 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170523/78d7405e/attachment.bin>


More information about the cfe-commits mailing list