[PATCH] D33393: [PATCH] Libcxxabi Demangler PR32890

Marcel Boehme via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 22 23:13:45 PDT 2017


marcel added inline comments.


================
Comment at: src/cxa_demangle.cpp:3078-3079
                     ++t1;
-                db.names.back().first.insert(db.names.back().first.begin()+7, t0, t1);
+                if (db.names.back().first.length() > 7)
+                  db.names.back().first.insert(db.names.back().first.begin() + 7, t0, t1);
                 t0 = t1;
----------------
dexonsmith wrote:
> Should this be `>= 7`?
You are right. Thanks for spotting this. Updating the patch.


https://reviews.llvm.org/D33393





More information about the cfe-commits mailing list